Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated lots of natives #1221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated lots of natives #1221

wants to merge 1 commit into from

Conversation

BJDubb
Copy link

@BJDubb BJDubb commented Nov 5, 2024

updated the following natives

AUDIO/PlaySoundFrontend.md
AUDIO/SetAudioFlag.md
DECORATOR/DecorSetInt.md
ENTITY/ApplyForceToEntity.md
ENTITY/AttachEntityToEntityPhysically.md
ENTITY/SetEntityLoadCollisionFlag.md
ENTITY/SetEntityLodDist.md
ENTITY/SetEntityProofs.md
GRAPHICS/StartParticleFxLoopedAtCoord.md
HUD/SetMinimapComponent.md
OBJECT/AddExtendedPickupProbeArea.md
OBJECT/N_0xd4a7a435b3710d05.md
OBJECT/SetObjectPhysicsParams.md
PATHFIND/GetRandomVehicleNode.md
TASK/TaskCombatPed.md

colistro123
colistro123 reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@colistro123 colistro123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the stance on batch updates remains the same, but from what I understand, they are not accepted due to PRs being time-consuming and prone to human error (to some degree).

#1048 (comment)

@PsychoShock
Copy link
Contributor

I'm not sure if the stance on batch updates remains the same, but from what I understand, they are not accepted due to PRs being time-consuming and prone to human error (to some degree).

#1048 (comment)

I would agree when changes are natives name changed, added params, etc, but here it's mostly descriptions and param descriptions added + re-formatted correctly. I wouldn't see why, this is (from the quick look) nice work and respecting all the signature from docs.

@colistro123
Copy link
Contributor

I'm not sure if the stance on batch updates remains the same, but from what I understand, they are not accepted due to PRs being time-consuming and prone to human error (to some degree).
#1048 (comment)

I would agree when changes are natives name changed, added params, etc, but here it's mostly descriptions and param descriptions added + re-formatted correctly. I wouldn't see why, this is (from the quick look) nice work and respecting all the signature from docs.

Yeah, looked further and it's mostly just parameter name changes and descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colistro123 colistro123 colistro123 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BJDubb @PsychoShock @colistro123